Remove signal reason unable_to_verify_signature and replace with signature_rejected #3094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces an unsupported signal reason
unable_to_verify_signature
withsignature_rejected
to keep the number of signal reasons small.Signal reason
unable_to_verify_signature
was added in #2945 but wasn't added to the rails app - this lead to builds getting stuck running. This has now been fixed in the rails app by handling unknown signal reasons but during that investigation I found existing discussion around additional signal reasons which argues not to add more signal reasons. To discourage more signal reasons, and to avoid not adding them to the app I've added some code comments.Context
Escalation
Linear
Testing
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)