Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signal reason unable_to_verify_signature and replace with signature_rejected #3094

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

jordandcarter
Copy link
Contributor

@jordandcarter jordandcarter commented Nov 17, 2024

Description

Replaces an unsupported signal reason unable_to_verify_signature with signature_rejected to keep the number of signal reasons small.

Signal reason unable_to_verify_signature was added in #2945 but wasn't added to the rails app - this lead to builds getting stuck running. This has now been fixed in the rails app by handling unknown signal reasons but during that investigation I found existing discussion around additional signal reasons which argues not to add more signal reasons. To discourage more signal reasons, and to avoid not adding them to the app I've added some code comments.

Context

Escalation
Linear

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love some thorough commenting ✨

@jordandcarter jordandcarter merged commit 68fac8d into main Nov 18, 2024
2 checks passed
@jordandcarter jordandcarter deleted the remove-signal-reason-unable-to-verify-signature branch November 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants