Prefix fatal error message with 'buildkite-agent:' #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordandcarter
deleted the
unambiguous-buildkite-agent-fatal-error-message
branch
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the agent exits and prints an error message prefix the message with
buildkite-agent:to provide clarity as to where the error came from. Our buildkite-agent cli is often used in scripts and when it exits with an error it isn't always obvious to the user what printed the error. It is common practice for cli tools to prefix error messages with the tool name.Context
https://linear.app/buildkite/issue/PS-217/prefix-fatal-error-messages-with-buildkite-agent
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)