feat(gcp): add env vars for buildkite queues and gcp project id #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
approved these changes
Oct 18, 2023
| @@ -4,7 +4,7 @@ import ( | |||
| "errors" | |||
| "flag" | |||
| "fmt" | |||
| "io/ioutil" | |||
| "io" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is no functionality that supports population of
gcpProjectIdandqueuesvia environment variables. This limits our ability to run this where config is dynamically populated andgcpProjectId/queuesattributes are a concern of the execution environment and not coupled to binary invocation.Intent
Use
GCP_PROJECT_IDandBUILDKITE_QUEUEenvironment variables to populate config.Notes
gcpProjectIDis an empty string we fall back to the environment variableGCP_PROJECT_ID.queuesaren't specified (i.e.len(queues) == 0) we fall back toBUILDKITE_QUEUE(same as AWS lambda) environment variables.These changes are backwards compatible to existing usage of this binary. Happy to discuss implementation details if maintainers feel otherwise :)
Reviewers
@triarius @DrJosh9000 PTAL.