Add New Relic backend #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
reviewed
May 13, 2019
lox
reviewed
May 13, 2019
lox
reviewed
May 13, 2019
lox
reviewed
May 13, 2019
|
This looks great! Some extremely minor nitpicks, although would happily merge as is. |
- Rename Dispose to Close to be more idiomatic with Go - Use strings.EqualFold for case insensitive comparison - Implement a backend Closer interface to be more generic
|
@lox Made some updates w.r.t. your suggestions, please re-review 😄 |
lox
reviewed
May 14, 2019
lox
reviewed
May 14, 2019
|
Made some more minor nitpicks @ChloeHutchinson! |
|
Made another update, thanks @lox |
|
🙌🏻 |
|
Will put this out in a new version shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds New Relic Insights monitoring integration to
buildkite-agent-metrics. I discovered NR does not accept custom Cloudwatch metrics out of the box so this change was born out of a need to write glue code to forward these metrics to New Relic. This work has been tested and is functional in Culture Amp's continuous integration environment as a Lambda using AWS SAM to deploy and manage it. Further rationale for why this might be considered is that New Relic'sgo-agentis, mercifully, a standalone dependency. 🎉Changes
backend/newrelic.godriver to support publishing New Relic custom eventslambda/main.goto enable this as an optional backend for the AWS Lambda binarygo-agentdependencyNotable areas
lambda/main.goinvokes a typecast check and a call to a disposal method. Since as far as I can tell the NR backend is the only one that might require this, I didn't think it necessary to add it to the base interface for all backend implementations. Still, I'd appreciate your thoughts if there's a cleaner way to approach this (I'm pretty new to golang 😳).