Prefer /usr/bin/env bash #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `/bin/bash`, which may help this script support slightly more systems (e.g. NixOS), where `/bin/bash` doesn't exist.
13 tasks
wpcarro
added a commit
to wpcarro/nixpkgs
that referenced
this pull request
May 23, 2022
While awaiting this PR: buildkite/cli#124 TIL `patchShebangs` exists (ty @Steri)
|
This script is only run by CI and shouldn't be used within the cli utility. Does this cause issues for you? |
It's been awhile, so I forget which script was causing me issues, but I know at least one of them was. I fixed this on the NixOS side of things, so this is less of a big deal IMO: NixOS/nixpkgs#173311 |
pda
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Seems reasonable 👍🏼
Good job working around it over in NixOS/nixpkgs#173311 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
/bin/bash, which may help this script support slightly moresystems (e.g. NixOS), where
/bin/bashdoesn't exist.