SUP-1619: Agent bulk stopping #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james2791
force-pushed
the
SUP-1619-Agent-Bulk-Stop
branch
from
b41b278 to
4345d5c
Compare
james2791
requested review from
jradtilbrook,
mcncl and
lizrabuya
as code owners
mcncl
reviewed
Dec 22, 2023
mcncl
previously approved these changes
Dec 22, 2023
mcncl
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to stop agents in bulk - passing in an arbitrary number as arguments to the
bk agent stopcommandExample input:
bk agent stop 45c92047-689e-45b8-a3f7-601b6ac14cc9 92c614c0-8d8f-4857-93c6-d499e21a755b 06bb968f-1fd7-4210-9c34-c9f456b41e44Output (on executing the command)
Final output (with an example of errors surfacing):
Each stop is subsequently made with a new bubble tea program: and as each API request is completed - either success or outputted error surfaces (with the status code/message)
On the case of no agents slug/UUIDs passed through to
bk agent stop, this also introducesSilenceUsageto the root command: which will not surface usage prompts when an error is returned by any command onbk.