SUP-1560 Add bk build new #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizrabuya
requested review from
jradtilbrook,
mcncl and
james2791
as code owners
jradtilbrook
reviewed
Jan 9, 2024
pkg/cmd/build/new.go
Outdated
| DisableFlagsInUseLine: true, | ||
| Use: "new <pipeline> [flags]", | ||
| Short: "Creates a new pipeline build", | ||
| Args: cobra.ArbitraryArgs, |
There was a problem hiding this comment.
I think this should be:
Suggested change
| Args: cobra.ArbitraryArgs, | |
| Args: cobra.ExactArgs(1), |
There was a problem hiding this comment.
I'll make this change together with the suggestions below.
pkg/cmd/build/new.go
Outdated
| It accepts {pipeline_slug}, {org_slug}/{pipeline_slug} or a full URL to the pipeline as an argument. | ||
| `), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| fmt.Println("build new command args here: ", args) |
There was a problem hiding this comment.
Looks like debugging left in?
pkg/cmd/build/new.go
Outdated
| `), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| fmt.Println("build new command args here: ", args) | ||
| if len(args) == 1 { |
There was a problem hiding this comment.
You won't need this with the change to line 26 above
jradtilbrook
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bk build newto create build with a pipeline name as argument