Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-1903 Add path based pipeline resolver #225

Conversation

jradtilbrook
Copy link
Contributor

This adds a resolver that uses the current path and API results to determine a pipeline automatically for the user.

@jradtilbrook jradtilbrook marked this pull request as ready for review April 25, 2024 08:45
@mcncl
Copy link
Contributor

mcncl commented Apr 25, 2024

I'm not sold on the resolvers being in the pipeline package, especially in things like build commands where you aren't really resolving a pipeline.

I think there should be a resolver(s) package within internal that houses the various different types of resolver. For examples when we eventually have a cluster resolver will that be contained within the pipeline package?

@jradtilbrook
Copy link
Contributor Author

I agree @mcncl 👍

I've made a change to the structure now, what do you think?

@jradtilbrook jradtilbrook merged commit ebb4bcf into 3.x Apr 26, 2024
1 check passed
@jradtilbrook jradtilbrook deleted the sup-1903-resolver-function-implementation-for-api-pipeline-loader branch April 26, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants