Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-1596 Configure goreleaser to create github releases #229

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

jradtilbrook
Copy link
Contributor

This updates the goreleaser config to allow it to create github releases.

@jradtilbrook
Copy link
Contributor Author

I used this config to create a release against my fork and it looks like its what we want: https://github.com/jradtilbrook/bk-cli/releases

Copy link
Contributor

@mcncl mcncl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Do we want it to remain in draft?

@jradtilbrook
Copy link
Contributor Author

Nice!

Do we want it to remain in draft?

@mcncl I'm thinking yes just so we can have a final check over it. At least for now, and when we get more confident and automated, maybe then we can just let it go for it straight awy

@jradtilbrook jradtilbrook merged commit 3910778 into 3.x Apr 30, 2024
1 check passed
@jradtilbrook jradtilbrook deleted the sup-1596-configure-goreleaser-to-release-to-github branch April 30, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants