Sup 2313/fix view #285
Merged
Sup 2313/fix view #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcncl
requested review from
jradtilbrook,
lizrabuya and
PriyaSudip
as code owners
jradtilbrook
approved these changes
Jun 14, 2024
| @@ -16,8 +16,8 @@ func BuildSummary(build *buildkite.Build) string { | |||
| buildCreator(build), | |||
| build.CreatedAt.UTC().Format(time.RFC1123Z)) | |||
| hash := *build.Commit | |||
| if len(hash) >= 7 { | |||
There was a problem hiding this comment.
Ohh could hash, or rather build.Commit actually be null even? So should check for that as well? I guess technically it could 🤷♂️ so might be best to check regardless
There was a problem hiding this comment.
@jradtilbrook that isn't a change in this pr
There was a problem hiding this comment.
And Go will just return an empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this ensures we don't get seg faults on non-command job outputs.