Build resolver for user's UUID #295
Conversation
lizrabuya
requested review from
jradtilbrook,
mcncl and
PriyaSudip
as code owners
| "github.com/buildkite/go-buildkite/v3/buildkite" | ||
| ) | ||
|
|
||
| func ResolveBuildFromCurrentUserId(uuid string, pipelineResolver pipelineResolver.PipelineResolverFn, f *factory.Factory) BuildResolverFn { |
There was a problem hiding this comment.
This isn't necessarily the current users ID. It could be any user so we should remove that from the name
| if len(builds) == 0 { | ||
| // we error here because this resolver is explicitly used so any case where it doesn't resolve a build is a | ||
| // problem | ||
| return nil, fmt.Errorf("failed to find a build for current user (%s)", userInfo) | ||
| } |
There was a problem hiding this comment.
I wonder if this applies now with these other resolvers? I suppose if the user doesn't have any builds its not really an error, we could just show a helpful message without it being an error
There was a problem hiding this comment.
I guess thats right, and for consistency too as we do the same for pipelines resolver. I'll update this to not error when no builds are found
There was a problem hiding this comment.
actually its probably more nuanced than that. the --user resolver might want to error if that user doesnt exist vs. if the user does exist but doesnt have any builds
There was a problem hiding this comment.
@jradtilbrook , i will raise a different PR to implement this as it will have to be the same behavior for all build resolvers and ensure that this is handled as expected.
There was a problem hiding this comment.
if the user does not exist, or is invalid the api returns an error, which is also returned by the resolver. So that should be covered.
There was a problem hiding this comment.
Looks good. @lizrabuya can you also create a card to come back and add this resolver to the build commands (its not used just yet but thats intentional)
Implement a build resolver for a given user uuid