Add plugins-path and switch to temp dirs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Good call on the defer's, I can't remember why I didn't clean them up afterwards 🤔 I clearly wrote #20 whilst I was half asleep. |
|
😁 I'm just stoked I wrote and ran some local Golang code |
|
I am too! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20 we added a temp file path for builds dir, but I think this was meant to be a temp directory and not a file? This fixes that, adds a plugins-path too, so that you can run pipelines that use plugins within a cleanroom environment (like a minimal Docker container).
Tested locally, and seems to work 👌🏼