include go routines #304
include go routines #304
Conversation
PriyaSudip
requested review from
jradtilbrook,
mcncl and
lizrabuya
as code owners
internal/cluster/query.go
Outdated
| @@ -27,18 +28,37 @@ func QueryCluster(ctx context.Context, OrganizationSlug string, ClusterID string | |||
| Queues: []Queue{}, | |||
| } | |||
|
|
|||
| queueChannel := make(chan Queue, len(q.Organization.Cluster.Queues.Edges)) | |||
| errorChannel := make(chan error, len(q.Organization.Cluster.Queues.Edges)) | |||
There was a problem hiding this comment.
This error channel doesn't seem to ever be read from?
There was a problem hiding this comment.
What would be the best place to send this information?
There was a problem hiding this comment.
Used errgroup to handle this
There was a problem hiding this comment.
This looks okay but its all done manually. This page https://gobyexample.com/waitgroups links out to the errgroup package which will make this much simpler: https://pkg.go.dev/golang.org/x/sync/errgroup
If you search the codebase, you'll see an example of it already in use as well I think
PriyaSudip
force-pushed
the
add/go-routines
branch
from
9d5072b to
79fd86d
Compare
Thanks @jradtilbrook as discussed I have made changes to include err group and instead of channel added array of queues and go routines based on the queue index |
Adding go routines to run queue agent querying in parallel.
With agents:
Without queue: