Update go buildkite #336
Merged
Update go buildkite #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
requested review from
jradtilbrook,
mcncl,
lizrabuya and
PriyaSudip
as code owners
moskyb
force-pushed
the
update-go-buildkite
branch
from
4a901e1 to
5205cb7
Compare
Using roundtrippers to modify HTTP requests for testing is pretty confusing, especially when there's a great testing tool right there for us to use! This also lets us completely remove the factory's `HttpClient` member
moskyb
force-pushed
the
update-go-buildkite
branch
from
5205cb7 to
f925901
Compare
jradtilbrook
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: Updates this tool to use the latest version of
go-buildkite, v3.12. Included in this PR:httptestlibrary, which is possible now that we can set the baseURL of the buildkite library!