Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standardised flag; not camel case #401

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Use standardised flag; not camel case #401

merged 2 commits into from
Nov 20, 2024

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Nov 19, 2024

Changes

  • Standardise the use of the envFile flag to that it is used with --env-file instead
  • Add a deprecated warning to the envFile flag
  • If envFile is used then normalise to --env-file

PriyaSudip
PriyaSudip previously approved these changes Nov 19, 2024
View reviewed changes
@mcncl mcncl enabled auto-merge (squash) November 19, 2024 01:19
@mcncl mcncl requested a review from PriyaSudip November 19, 2024 01:24
lizrabuya
lizrabuya approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcncl mcncl merged commit af15027 into main Nov 20, 2024
1 check passed
@mcncl mcncl deleted the bm/use_flag_standard branch November 20, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrabuya lizrabuya lizrabuya approved these changes

@jykingston jykingston Awaiting requested review from jykingston jykingston is a code owner

@PriyaSudip PriyaSudip Awaiting requested review from PriyaSudip PriyaSudip is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcncl @PriyaSudip @lizrabuya