Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for an alternate buildkite.com to be specified #406

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

CerealBoy
Copy link
Contributor

Given a BUILDKITE_GRAPHQL_ENDPOINT env is found, use it as the base for the GraphQL API calls being made instead of the built-in default.

@CerealBoy CerealBoy marked this pull request as ready for review November 26, 2024 23:28
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

edit, looks like i don't have approve power 😅

@dabarrell
Copy link

Looks like this only handles graphql - it'd be good if we didn't have to specify the graphql and rest API base URLs separately

@mcncl
Copy link
Contributor

mcncl commented Nov 26, 2024

LGTM!

edit, looks like i don't have approve power 😅

You can approve, but it means nothing 😛

@CerealBoy CerealBoy merged commit dee90e7 into main Nov 27, 2024
1 check passed
@CerealBoy CerealBoy deleted the feature/diy-buildkite-dot-com branch November 27, 2024 01:29
@CerealBoy
Copy link
Contributor Author

Looks like this only handles graphql - it'd be good if we didn't have to specify the graphql and rest API base URLs separately

@dabarrell There doesn't appear to be any rest API usage at the moment, only graphql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants