-
Notifications
You must be signed in to change notification settings - Fork 268
Update source_control.md #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update source_control.md #2080
Conversation
Your Render PR Server URL is https://bk-docs-pr-2080.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-ch3arrlgk4q8s0b43660. |
@@ -13,3 +13,5 @@ Buildkite integrates with several popular code repository management systems (RM | |||
* [Bitbucket Server](/docs/integrations/bitbucket-server) | |||
* [Phabricator](/docs/integrations/phabricator) | |||
* [Other Git servers](/docs/integrations/git) | |||
|
|||
Note: Commit Status uses the latest built commit on a pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stephanieatte, sorry this has taken me a while to get around to. Can you please unpack this a bit more for me? What is the issue customers are running into?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbelton-buildkite No worries, the Customers get confused about if the commit statuses feature works with the first or latest build on a pipeline. So having it explicitly stating this in our docs will be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit out of place here, what do you think about including it on the relevant pages? Thinking:
- GitHub + Enterprise: In the first paragraph of each page?
- Bitbucket: Enable commit status updates
Looks like it's not supported or not mentioned in the others.
Perhaps just something like:
The commit status on a PR shows the result of the most recent build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbelton-buildkite I see but I didn't want to repeat the informtion, but I understand it looks out of place. we might have to put it on all the pages
We kept getting questions about commit status, we needed more clarification in the docs