Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

implement -number-of-tasks cli arg #22

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

sherzberg
Copy link
Contributor

I needed a way to run multiple instances of the same task at once so this PR helps with that.

@lox
Copy link
Contributor

lox commented Apr 4, 2019

Thanks! How about we go with --count to match the Count param on RunTaskInput?

@sherzberg sherzberg force-pushed the feature/number-of-tasks branch from 4453197 to 5ca4a1d Compare April 4, 2019 21:44
@sherzberg sherzberg force-pushed the feature/number-of-tasks branch from 5ca4a1d to 92fe706 Compare April 4, 2019 21:45
@sherzberg
Copy link
Contributor Author

Thanks for the quick response! Count sounds great. Just updated my pr.

@lox lox merged commit 0be98c9 into buildkite:master Apr 4, 2019
@lox
Copy link
Contributor

lox commented Apr 4, 2019

Thanks for the contribution!

@@ -92,6 +97,7 @@ func main() {
r.SecurityGroups = ctx.StringSlice("security-group")
r.Subnets = ctx.StringSlice("subnet")
r.Environment = ctx.StringSlice("env")
r.Count = ctx.Int64("number-of-tasks")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lox sorry, but I missed this! New PR coming :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeep I should have caught that too, sorry! Too early in the morning here :D

@lox
Copy link
Contributor

lox commented Apr 4, 2019

Released in https://github.com/buildkite/ecs-run-task/releases/tag/v1.3.0, thanks for taking the time to put in a PR @sherzberg, we welcome any future changes or issues you encounter!

dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants