This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
fix region error. fix env vars not propagated to task if -s not provided #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Eli-Goldberg
commented
Feb 9, 2020
Eli-Goldberg
commented
- AWS Region had to be provided by AWS_REGION env var. Now -r flag can be specified.
- "-e" flag was not honored if "-s" flag was not provided. Now env vars provided with "-e" are propagated to the task as overrides, regardless of the "-s" flag.
- Lint errors
- added some common values to .gitignore
|
ecs-run -r us-east-1 and got an error saying --region wasnt provided (aws expected an env var) - so I added that. Then it ran but my task wasnt getting any of the "-e" flags (NODE_ENV above). |
|
@lox |
Eli-Goldberg
force-pushed
the
region-env-fixes
branch
from
6101453 to
3308e7d
Compare
|
Thanks! Fixed a conflict. |
dsantibanezvera
pushed a commit
to dsantibanezvera/ecs-run-task
that referenced
this pull request
Sep 28, 2020
fix region error. fix env vars not propagated to task if -s not provided
dsantibanezvera
pushed a commit
to dsantibanezvera/ecs-run-task
that referenced
this pull request
Sep 28, 2020
fix region error. fix env vars not propagated to task if -s not provided
dsantibanezvera
pushed a commit
to dsantibanezvera/ecs-run-task
that referenced
this pull request
Sep 28, 2020
fix region error. fix env vars not propagated to task if -s not provided
dsantibanezvera
pushed a commit
to dsantibanezvera/ecs-run-task
that referenced
this pull request
Sep 28, 2020
fix region error. fix env vars not propagated to task if -s not provided
dsantibanezvera
pushed a commit
to dsantibanezvera/ecs-run-task
that referenced
this pull request
Sep 28, 2020
fix region error. fix env vars not propagated to task if -s not provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.