Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update to urfav/cli v2 #32

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Update to urfav/cli v2 #32

merged 1 commit into from
Mar 9, 2020

Conversation

vektah
Copy link
Contributor

@vektah vektah commented Mar 4, 2020

This library recently made a breaking change that makes ecs-run-task un go-gettable without GO111MODULES=on

@yob
Copy link
Contributor

yob commented Mar 4, 2020

Thanks for bumping this dependency @vektah!

Does this fix an issue on master, or are you helping us avoid falling behind on a dependency that has shipped a beraking change?

@vektah
Copy link
Contributor Author

vektah commented Mar 6, 2020

Does this fix an issue on master, or are you helping us avoid falling behind on a dependency that has shipped a beraking change?

Running go get github.com/buildkite/ecs-run-task with a clean gopath will currently fail.

It can be worked around by doing GO111MODULE=on go get github.com/buildkite/ecs-run-task but it would be nice if normal go get keeps on working, at least until go switch the default over.

@yob
Copy link
Contributor

yob commented Mar 9, 2020

Thanks, I've confirmed this fixes the issue using go get without modules 👍

@yob yob merged commit e651006 into buildkite:master Mar 9, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
dsantibanezvera pushed a commit to dsantibanezvera/ecs-run-task that referenced this pull request Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants