Publish to both main and master for the time being
#1129
Conversation
With v6, we will be renaming the default branch to main using the GitHub UI. When this change is made, the next build on the main branch won't push a stack template to the same location. So let's push to both locations for now.
triarius
force-pushed
the
pdp-1109-publish-to-both-master-and-main-for-the-time-being
branch
from
4596f0e
to
bd08fa2
Compare
| exit 0 | ||
| fi | ||
|
|
||
| # TODO: remove "master" from this list |
There was a problem hiding this comment.
This is largely a hypothetical, but if we all forget what this was about, when would the right time to remove "master" be? 6 months from now?
There was a problem hiding this comment.
i'm a big fan of time bomb comments for this - eg # If you're reading this and the date is after YYYY-MM-DD the you should delete master from this list. it's a concrete call to action, and avoids both the bystander effect and the murky who/when/how of a TODO - the who is the reader, the when is right now, the how should be made clear by the comment, ideally
There was a problem hiding this comment.
i remember ages ago finding a rust crate that was able to parse these and automatically fail CI if it found any hanging time bombs... lost to the sands of the internet now though
There was a problem hiding this comment.
I did make a ticket about it: https://linear.app/buildkite/issue/PDP-1110/remove-publishing-elastic-stack-to-master
I put it in the backlog. I think moving to PDP triage might make it more visible.
triarius
deleted the
pdp-1109-publish-to-both-master-and-main-for-the-time-being
branch
…er-and-main-for-the-time-being
…er-and-main-for-the-time-being
With v6, we will be renaming the default branch to main using the GitHub UI. When this change is made, the next build on the main branch won't push a stack template to the same location. So let's push to both locations for now.