Increase cancel grace period to 60s #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
approved these changes
Jun 27, 2023
triarius
changed the title
It was found on Amazon Linux 2023 that the default 10s grace period was insufficient to allow the bootstrap to tear down cleanly when a job is cancelled from the Buildkite API.
triarius
force-pushed
the
pdp-1225-increase-grace-period-for-cancellation-sigkill
branch
from
ebd7051
to
d21d893
Compare
triarius
deleted the
pdp-1225-increase-grace-period-for-cancellation-sigkill
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found on Amazon Linux 2023 that the default 10s grace period was
insufficient to allow the bootstrap to tear down cleanly when a job is
cancelled from the Buildkite API.