Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chown the builds before checkout #33

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Chown the builds before checkout #33

merged 1 commit into from
Mar 18, 2016

Conversation

vektah
Copy link
Contributor

@vektah vektah commented Mar 18, 2016

This PR adds a

chown -R  buildkite-agent.buildkite-agent /var/lib/buildkite-agent/builds

before doing a checkout.

This works around permission issues caused volume mounts leaving files owned by root in the checkout.

I think the long term aim should be #32, as it fixes the underlying security issue and not just the symptom, but it needs more thorough testing.

@lox
Copy link
Contributor

lox commented Mar 18, 2016

This fixes #30

lox added a commit that referenced this pull request Mar 18, 2016
@lox lox merged commit 87513d2 into master Mar 18, 2016
@lox lox deleted the chown-before-checkout branch March 18, 2016 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants