Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter linter #125

Merged
merged 9 commits into from
May 13, 2024
Merged

Stricter linter #125

merged 9 commits into from
May 13, 2024

Conversation

toote
Copy link
Collaborator

@toote toote commented May 10, 2024

I have long been running rubocop without -l as a stricter linter variant that mostly complains about:

  • code complexity
  • block length
  • trailing whitespace

This PR includes refactorings to remove the last 8 warnings (and ignores one).

To further prevent this from being an issue I created an EditorConfig file to prevent the easier automated warnings (as long as your IDE supports it, which it should - maybe with an extension)

@toote toote requested review from pzeballos and james2791 as code owners May 10, 2024 19:24
Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 💚

@james2791 james2791 merged commit b56db44 into toote_steps_refactoring May 13, 2024
1 check passed
@james2791 james2791 deleted the toote_stricter_linter branch May 13, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants