Catch IndexError #55
Catch IndexError #55
Conversation
PIE-71 rspec-buildkite-analytics sometimes fails with IndexError
We saw this bug happen in a few builds: https://buildkite.com/buildkite/buildkite/builds/37449#d2e67d74-8a1d-4d74-8802-01cb65755abb https://buildkite.com/buildkite/buildkite/builds/37511#1a95eb50-8bed-4568-b220-a9a9fede9835 It seems that this is caused by non-thread safe use of the underlying SSL Socket library, which we are technically culpable of 😅, but also it shouldn't bubble up as an array error! I raised this as an issue Which has spawned this fix, which has now been merged ruby/openssl#453 So it shouldn't manifest as an IndexError anymore…but I am not sure what it will manifest as! I think let's just monitor and see, and hopefully this error crops up again, and will manifest in a different way, or manifest in a way that we're already dealing with. |
There was a problem hiding this comment.
As much as I dislike catching such a non-descript error as this one, I think it's the only simple path forward. One caveat though...can you put a ticket in Linear for us to reassess a proper fix?
The thing I'm not sure about: if an IndexError is thrown in other parts of the application that includes this gem, will it get caught here???
This will only catch IndexError raised inside the call stack of these methods. So yes, we risk catching any and all index errors that occur in anything called inside initialize and transmit but nothing outside (eg test/application code).
In normal operation this isn't the kind of error you'd expect to see so I think it's ok but with the caveat raised above.
Side note: I think this has less risk than pinning OpenSSL dependency to a point release as in the related ticket.
On occasion we're seeing the analytics gem hard fail (i.e. makes the tests fail) with
IndexError. It's not great. Let's catch the error and trigger our reconnect flow. Alternate approach to #54.The thing I'm not sure about: if an
IndexErroris thrown in other parts of the application that includes this gem, will it get caught here???