Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Max rows not working with text without breakline char #50

Closed
Luchanso opened this issue Jun 19, 2017 · 2 comments
Closed

Max rows not working with text without breakline char #50

Luchanso opened this issue Jun 19, 2017 · 2 comments
Labels
bug

Comments

@Luchanso
Copy link

Max-rows not work with long strings:

Lorem ipsum dolor sit amet, consectetur adipisicing elit. Fuga aspernatur ut ullam rem ipsam. Fuga illo velit sapiente necessitatibus, voluptatum earum at quo magnam impedit, molestias aliquid, voluptates, sit odit. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Fuga aspernatur ut ullam rem ipsam. Fuga illo velit sapiente necessitatibus, voluptatum earum at quo magnam impedit, molestias aliquid, voluptates, sit odit. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Fuga aspernatur ut ullam rem ipsam. Fuga illo velit sapiente necessitatibus, voluptatum earum at quo magnam impedit, molestias aliquid, voluptates, sit odit. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Fuga aspernatur ut ullam rem ipsam. Fuga illo velit sapiente necessitatibus, voluptatum earum at quo magnam impedit, molestias aliquid, voluptates, sit odit.

Bug example:
image
@FrancescoCioria
Copy link
Contributor

Hi @Luchanso, it definitely sounds like a bug, thank you for reporting it!

@nemobot nemobot added the WIP label Jun 19, 2017
@FrancescoCioria FrancescoCioria mentioned this issue Jun 19, 2017
Merged
@FrancescoCioria
Copy link
Contributor

Ok, the only way to make it work reliably is to somehow get the textarea's computed lineHeight and use it with maxRows to compute maxHeight.

I opened a PR that does exactly this

giogonzo added a commit that referenced this issue Jun 19, 2017
@giogonzo
Merge pull request #51 from buildo/50-max_rows_not_working
7514b71 
#50: Max rows not working with text without breakline char (closes #50)
@nemobot nemobot removed the in review label Jun 19, 2017
@FrancescoCioria FrancescoCioria mentioned this issue Jul 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Luchanso @FrancescoCioria @nemobot