Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Fixes #117

Merged
merged 4 commits into from
Dec 31, 2018
Merged

Fixes #117

merged 4 commits into from
Dec 31, 2018

Conversation

FrancescoCioria
Copy link
Contributor

@FrancescoCioria FrancescoCioria commented Dec 5, 2018 •
edited
Loading

closes #118
closes #119

tests

  1. textarea still resizes correctly
  2. onResize called even if passed when already mounted and it's called with an Event:
    Image from Gyazo

@nemobot nemobot added the WIP label Dec 5, 2018
@nemobot nemobot added in review and removed WIP labels Dec 6, 2018
giogonzo
giogonzo approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@giogonzo giogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrancescoCioria FrancescoCioria merged commit 308798a into master Dec 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giogonzo giogonzo giogonzo approved these changes

Assignees
No one assigned
Labels
waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onResize types are wrong onResize not called if passed when component already mounted
3 participants
@FrancescoCioria @giogonzo @nemobot