Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

#54: this.dispatchEvent(UPDATE) called too often (closes #54) #55

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

FrancescoCioria
Copy link
Contributor

@FrancescoCioria FrancescoCioria commented Jun 27, 2017

Closes #54

Test Plan

tests performed

tested in Chrome, Safari 10 and IE11:

  • every example still works correctly
  • improve first example to programmatically change value to a long one after some seconds
    • it updates correctly

https://gyazo.com/b124280ad130733c0bc0193062966197

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

@giogonzo giogonzo merged commit a511f7b into master Jun 27, 2017
@nemobot
Copy link

nemobot commented Jun 27, 2017

@giogonzo giogonzo deleted the 54-thisdispatcheventupdate_called_too_often branch June 27, 2017 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants