This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
#23: Cookie expiration date (closes #23) #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoCioria
force-pushed
the
23-cookie_expiration_date
branch
from
October 5, 2016 10:44
540b99e
to
aae89b6
Compare
FrancescoCioria
force-pushed
the
23-cookie_expiration_date
branch
from
October 5, 2016 10:45
aae89b6
to
c670315
Compare
How about adding a unit test? The logic seems "complex" enough to deserve one |
You have basically already written it in the test plan ;-) |
gabro
suggested changes
Oct 5, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a unit test, then ok
gabro
approved these changes
Oct 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #23
Test Plan
tests performed
secondsSinceExpiration
cookieExpiration
--> 31536000 ✅ (default is{ years: 1 }
12345
-->12345
✅{ years: 1, days: 10, hours: 5 }
--> 32418000 ✅{}
--> 0 ✅tests not performed (domain coverage)