Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

#23: Cookie expiration date (closes #23) #24

Merged
merged 7 commits into from
Oct 5, 2016

Conversation

FrancescoCioria
Copy link
Contributor

@FrancescoCioria FrancescoCioria commented Oct 5, 2016

Issue #23

Test Plan

tests performed

  • log secondsSinceExpiration
    • don't pass cookieExpiration --> 31536000 ✅ (default is { years: 1 }
    • pass 12345 --> 12345
    • pass { years: 1, days: 10, hours: 5 } --> 32418000 ✅
    • pass {} --> 0 ✅

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

@nemobot nemobot added the WIP label Oct 5, 2016
@FrancescoCioria FrancescoCioria force-pushed the 23-cookie_expiration_date branch from 540b99e to aae89b6 Compare October 5, 2016 10:44
@FrancescoCioria FrancescoCioria force-pushed the 23-cookie_expiration_date branch from aae89b6 to c670315 Compare October 5, 2016 10:45
@gabro
Copy link
Member

gabro commented Oct 5, 2016

How about adding a unit test? The logic seems "complex" enough to deserve one

@gabro
Copy link
Member

gabro commented Oct 5, 2016

You have basically already written it in the test plan ;-)

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a unit test, then ok

@FrancescoCioria FrancescoCioria merged commit e8a0405 into master Oct 5, 2016
@nemobot
Copy link

nemobot commented Oct 5, 2016

@nemobot nemobot removed the in review label Oct 5, 2016
@FrancescoCioria FrancescoCioria deleted the 23-cookie_expiration_date branch October 5, 2016 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants