This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
#26: Use eslint-config-buildo (closes #26) #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
force-pushed
the
26-use_eslintconfigbuildo
branch
from
20d92a1 to
a170592
Compare
FrancescoCioria
suggested changes
Oct 13, 2016
| "eslint-loader": "^1.1.1", | ||
| "eslint-plugin-react": "^3.8.0", | ||
| "eslint-plugin-react": "^5", |
There was a problem hiding this comment.
this should be removed as it's already a dependency of buildo-eslint-config (https://github.com/buildo/eslint-config/blob/master/package.json#L29)
FrancescoCioria
approved these changes
Oct 13, 2016
FrancescoCioria
force-pushed
the
26-use_eslintconfigbuildo
branch
from
df16e0d to
bd4167d
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #26
Test Plan
tests performed
CI should pass