This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add a 'cookiePath' property #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! It seems like a reasonable addition and the code looks 👍 |
FrancescoCioria
approved these changes
May 3, 2017
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal to add a new "cookiePath" property.
This new property would fix a weird bug on IE: on my SPA (which uses react-router with history API), when the user clicks on the banner to close it, then navigate to another page, sometimes the cookie vanish and the banner is displayed again.
I think the bug is related to this: http://stackoverflow.com/questions/8292449/internet-explorer-sends-the-wrong-cookie-when-the-paths-overlap#8314164
If i force the cookie path to '/', i dont have the bug (and browser-cookie-lite does not force it). So this property let me set the path i wish.
I did not set a default value to not break the current behavior.