Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lodash and classnames should be deps, not devDeps #13

Closed
FrancescoCioria opened this issue Mar 23, 2017 · 0 comments
Closed

lodash and classnames should be deps, not devDeps #13

FrancescoCioria opened this issue Mar 23, 2017 · 0 comments
Assignees
@FrancescoCioria
Labels
bug

Comments

@FrancescoCioria
Copy link
Contributor

description

lodash and classnames are erroneously set as devDependencies as react-placeholder requires both to work

how to reproduce

  • {optional: describe steps to reproduce bug}

specs

move them to from devDeps to deps in package.json

misc

{optional: other useful info}
@FrancescoCioria FrancescoCioria self-assigned this Mar 23, 2017
@nemobot nemobot added the WIP label Mar 23, 2017
@FrancescoCioria FrancescoCioria mentioned this issue Mar 23, 2017
Merged
@nemobot nemobot added in review and removed WIP labels Mar 23, 2017
@gabro gabro closed this as completed in #14 Mar 23, 2017
gabro added a commit that referenced this issue Mar 23, 2017
@gabro
Merge pull request #14 from buildo/13-lodash_and_classnames_should
c86f568 
#13: lodash and classnames should be deps, not devDeps (closes #13)
@nemobot nemobot removed the in review label Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrancescoCioria FrancescoCioria

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FrancescoCioria @nemobot