Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CSS? #72

Closed
orangecoding opened this issue May 8, 2018 · 4 comments
Closed

Removed CSS? #72

orangecoding opened this issue May 8, 2018 · 4 comments
Labels
bug

Comments

@orangecoding
Copy link

In react-placeholder 3, you've obviously removed the css file from the npm package. Is it not needed anymore? If so, wouldn't it make sense to update the docs as well?
@Kaishiyoku
Copy link

Yeah - I also experienced that.

@FrancescoCioria
Copy link
Contributor

No, that's definitely a bug, I removed the script that transpiles the .scss into .css by mistake 🙈

@nemobot nemobot added the WIP label May 8, 2018
@FrancescoCioria FrancescoCioria mentioned this issue May 8, 2018
Merged
FrancescoCioria added a commit that referenced this issue May 8, 2018
@FrancescoCioria
Merge pull request #73 from buildo/72-removed_css
42c2b79 
#72: Removed CSS? (closes #72)
@nemobot nemobot removed the WIP label May 8, 2018
@FrancescoCioria
Copy link
Contributor

I released 3.0.1 with the fix

@FrancescoCioria FrancescoCioria mentioned this issue May 8, 2018
Closed
@jimthedev
Copy link

weee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jimthedev @orangecoding @FrancescoCioria @Kaishiyoku @nemobot