Merge pull request #951 from pivotal/v0.5.3-fix-ndr

Prevent possible Nil Pointer Reference. v0.5.3 version line.

pkg/config/lifecycle_provider.go

@@ -62,6 +62,7 @@ func (l *LifecycleProvider) UpdateImage(cm *corev1.ConfigMap) {
 	lifecycle, err := l.read(context.Background(), cm)
 	if err != nil {
 		l.lifecycleData.Store(configmapRead{err: err})
+		return
 	}
 
 	if l.isNewImage(lifecycle) {

pkg/config/lifecycle_provider_test.go

@@ -110,6 +110,9 @@ func testProvider(t *testing.T, when spec.G, it spec.S) {
 				Data: map[string]string{"image": "some-invalid-image", "serviceAccountRef.name": "some-service-account", "serviceAccountRef.namespace": "some-service-account-namespace"},
 			})
 			require.Equal(t, callBack.called, 1)
+
+			_, _, err := p.LayerForOS("linux")
+			require.Error(t, err)
 		})
 	})