Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning fails with Azure DevOps repos #1336

Closed
tomkennedy513 opened this issue Oct 2, 2023 · 0 comments · Fixed by #1337
Closed

Cloning fails with Azure DevOps repos #1336

tomkennedy513 opened this issue Oct 2, 2023 · 0 comments · Fixed by #1337

Comments

@tomkennedy513
Copy link
Collaborator

tomkennedy513 commented Oct 2, 2023 •
edited
Loading

When attempting to build from an Azure DevOps git repo, the clone will fail with an unexpected client error on https and empty git-upload-pack given on ssh.

After reviewing https://github.com/go-git/go-git/blob/52c2972976737a00fce91d7deb1278a6a460cae6/_examples/azure_devops/main.go#L21-L36, we need to remove multi_ack and multi_ack_detailed from our transport's unsupported capabilities.

The example does call out that additional fetches will fail, but this should not be an issue because we only fetch once per build.

Thank you to @CptNukey for reporting this!
tomkennedy513 added a commit that referenced this issue Oct 2, 2023
@tomkennedy513
Fix cloning with Azure DevOps Git
ae22217 
- remove multi_ack and multi_ack_detailed from unsupported capabilities
- see https://github.com/go-git/go-git/blob/52c2972976737a00fce91d7deb1278a6a460cae6/_examples/azure_devops/main.go\#L21-L36 for more info
- we should be able to remove this once go-git implements full support for v2 git with multi_ack

fixes #1336

Signed-off-by: Tom Kennedy <ktom@vmware.com>
@tomkennedy513 tomkennedy513 mentioned this issue Oct 2, 2023
Merged
sambhav pushed a commit that referenced this issue Oct 3, 2023
@tomkennedy513
Fix cloning with Azure DevOps Git (#1337)
b8c0d49 
- remove multi_ack and multi_ack_detailed from unsupported capabilities
- see https://github.com/go-git/go-git/blob/52c2972976737a00fce91d7deb1278a6a460cae6/_examples/azure_devops/main.go\#L21-L36 for more info
- we should be able to remove this once go-git implements full support for v2 git with multi_ack

fixes #1336

Signed-off-by: Tom Kennedy <ktom@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cloning with Azure DevOps Git buildpacks-community/kpack
1 participant
@tomkennedy513