Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1alpha1 images do not get a default PVC cache if it is unset #873

Closed
tylerphelan opened this issue Oct 27, 2021 · 1 comment
Closed

v1alpha1 images do not get a default PVC cache if it is unset #873

tylerphelan opened this issue Oct 27, 2021 · 1 comment
Assignees
@matthewmcnew
Labels
0.4.2 bug Something isn't working good first issue Good for newcomers

Comments

@tylerphelan
Copy link
Contributor

tylerphelan commented Oct 27, 2021 •
edited
Loading

If cache size is unset in v1alpha1 and there is a default storage class, default of 2GB should be set.
@tylerphelan tylerphelan changed the title v1alpha1 images do get a default PVC cache if it is unset v1alpha1 images do not get a default PVC cache if it is unset Oct 27, 2021
@matthewmcnew matthewmcnew added good first issue Good for newcomers bug Something isn't working labels Oct 28, 2021
@matthewmcnew matthewmcnew self-assigned this Nov 2, 2021
matthewmcnew added a commit that referenced this issue Nov 4, 2021
@matthewmcnew
Provide HasDefaultStorageClass & IsExpandable on webhook context
c7ef3b1 
- The conversion wehhook will call validation & defaulting which will lead to diverging behavior from the validation and defaulting webhooks
- This prevented v1alpha1 image resources from being defaulted with a volume cache because defaulting was taking place in the conversion webhook without the correct context
Resolves: #878 #873
@matthewmcnew matthewmcnew mentioned this issue Nov 4, 2021
Merged
matthewmcnew added a commit that referenced this issue Nov 4, 2021
@matthewmcnew
Provide HasDefaultStorageClass & IsExpandable on webhook context
66b3519 
- The conversion wehhook will call validation & defaulting which will lead to diverging behavior from the validation and defaulting webhooks
- This prevented v1alpha1 image resources from being defaulted with a volume cache because defaulting was taking place in the conversion webhook without the correct context
Resolves: #878 #873
@sambhav
Copy link
Contributor

sambhav commented Nov 6, 2021

This is closed by #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmcnew matthewmcnew

Labels
0.4.2 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewmcnew @tylerphelan @sambhav