-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Build resource documentation #1156
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 70.01% 67.57% -2.44%
==========================================
Files 132 132
Lines 6677 8004 +1327
==========================================
+ Hits 4675 5409 +734
- Misses 1573 2166 +593
Partials 429 429 see 110 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jjbustamante can we add some docs on how to rebuild/rebase with the build resource? |
Yeah, I will do that next week |
@samj1912 , I added some docs for rebuild and rebase, if can take a look it will be great |
@jjbustamante I noticed there is more than 1 kpack tutorial. What are your thoughts on moving this out the Build docs and into it's own tutorial? It'd still be great to reference it from there. |
I don't have problem with that, thinking about it, maybe we can add a link in the README, something like: And keep the link in the build resource page. @tomkennedy513 , @matthewmcnew any thoughts on this? |
I think a separate file makes sense like @hone suggested |
@tomkennedy513 @hone I just updated the PR, let me know how it looks now |
@jjbustamante Looks good! Can you just remove the WIP commits for this pr as well |
adding links from README and build resource. Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
c244eb0
to
5b88355
Compare
Done! @tomkennedy513 |
This PR adds some documentation to help understand users on how they achieved a similar outcome from a
pack build
usingBuild
resourceFixes #1130