Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.8.x] Deduplicate builders by diff id #1285

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

tomkennedy513
Copy link
Collaborator

same as #1268

also includes fixes for ci that have been cherry picked from 0.10.x

- This has been removed in the latest versions of kpack but is required for older versions
- This requires using a builder with the exisitng git2go buildpack that
  has not been open sourced at the moment

Signed-off-by: Tom Kennedy <ktom@vmware.com>
Signed-off-by: Tom Kennedy <ktom@vmware.com>
- On main the config directory schema has changed. When backporting the ci workflow that was not taken into consideration so it is using the wrong schema.

Signed-off-by: Tom Kennedy <ktom@vmware.com>
Signed-off-by: Tom Kennedy <ktom@vmware.com>
- This will remove duplicate layers that result from two buildpacks in a builder that have the same layer diff id

Co-authored-by Matthew McNew <mmcnew@vmware.com>
@tomkennedy513 tomkennedy513 requested a review from a team as a code owner July 24, 2023 21:43
@tomkennedy513 tomkennedy513 changed the title Deduplicate builders 0 8 [0.8.x] Deduplicate builders by diff id Jul 24, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.8.x@749297d). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                @@
##             release/v0.8.x    #1285   +/-   ##
=================================================
  Coverage                  ?   67.76%           
=================================================
  Files                     ?      123           
  Lines                     ?     7280           
  Branches                  ?        0           
=================================================
  Hits                      ?     4933           
  Misses                    ?     1937           
  Partials                  ?      410           

@sambhav sambhav merged commit b4089a3 into release/v0.8.x Jul 25, 2023
@sambhav sambhav deleted the deduplicate-builders-0-8 branch July 25, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants