Shorten service binding secret volume mount names #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The volume name has a limit of 63 characters. Using the `service-binding-secret-` prefix exhaust a significant part of this limit. Given that the binding name is a user input it is not too hard to hit that limit. Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 140 140
Lines 8886 8886
=======================================
Hits 5984 5984
Misses 2393 2393
Partials 509 509 ☔ View full report in Codecov by Sentry. |
tomkennedy513
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The volume name has a limit of 63 characters. Using the
service-binding-secret-prefix exhaust a significant part of this limit. Given that the binding name is a user input it is not too hard to hit that limit.While this PR solves our immediate problem, you could consider whether shortening all the volume names makes sense. One way of keeping names within the limit is to use a name of
sha-1(prefix+binding-name)