Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements RFC0013 for generating app source project metadata #287

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

carlo-colombo
Copy link
Contributor

Example of generated toml file

[source]
type = "git"

  [source.version]
  commit = "3b5a3...698317"

  [source.metadata]
  repository = "https://github.com/carlo-colombo/java-maven.git"
  revision = "3b5a3d...698317"

                                                                                          - when fetching the git repository it creates as for buildpacks/lifecycle#230 a project-metadata.toml
                                                                                            file containing information about the git repository
                                                                                          - the layers volume need to be mounted on a different path because if mounted on `/layers` because the `prepare` container is
                                                                                            built itself using `pack` and already contains a `/layers` directory. The specific failure is the launcher failing to read
                                                                                            some expected file.
                                                                                          - this change can work independently from buildpacks/lifecycle#230
@marcingrzejszczak
Copy link

Codecov Report

Merging #287 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   67.38%   67.44%   +0.06%     
==========================================
  Files          77       77              
  Lines        3097     3115      +18     
==========================================
+ Hits         2087     2101      +14     
- Misses        762      764       +2     
- Partials      248      250       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c736f6...d2cb94d. Read the comment docs.

Copy link
Collaborator

@matthewmcnew matthewmcnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thisisnotashwin
Copy link

Holding off on the merge until buildpacks/lifecycle#230 gets merged

@carlo-colombo
Copy link
Contributor Author

@ashwin-venkatesh buildpacks/lifecycle#230 has been merged

@thisisnotashwin thisisnotashwin merged commit 9b57daa into buildpacks-community:master Feb 18, 2020
@thisisnotashwin
Copy link

Thanks for the contribution @carlo-colombo 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants