Make the Image reconciliation generate deterministic build names #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcnew
requested review from
jromero,
tylerphelan,
dumez-k,
sambhav and
tomkennedy513
tomkennedy513
approved these changes
Oct 4, 2021
|
The risk here would be that the build name for the next build has already been created manually outside of the image reconciler loop the image reconciler would never be able to successfully reconcile. |
dumez-k
approved these changes
Oct 4, 2021
matthewmcnew
force-pushed
the
deterministic-build-names
branch
from
f571674
to
cc25558
Compare
kpack appears to periodically reconcile the Image before its internal Build lister is updated with the previous reconcile's Build. This leads to subsequent reconciles creating duplicate builds. By using deterministic build names the reconcile of an image will result in an error attempting to create a new build if a image reconcile starts before the informer has the previously created build.
matthewmcnew
force-pushed
the
deterministic-build-names
branch
from
cc25558
to
e956740
Compare
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 68.69% 67.63% -1.07%
==========================================
Files 114 114
Lines 5054 5014 -40
==========================================
- Hits 3472 3391 -81
- Misses 1210 1260 +50
+ Partials 372 363 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kpack appears to periodically reconcile the Image before its internal Build lister is updated with the previous reconcile's Build. This leads to subsequent reconciles creating duplicate builds.
By using deterministic build names the reconcile of an image will result in an error attempting to create a new build if a image reconcile starts before the informer has the previously created build.