Include lifecycle dir in tar header #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@addreas Thanks for the fix! @matthewmcnew this sounds similar to the bug I was talking about last week. |
matthewmcnew
approved these changes
Oct 25, 2021
tomkennedy513
approved these changes
Oct 25, 2021
Codecov Report
@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 67.36% 67.36%
=======================================
Files 115 115
Lines 5222 5222
=======================================
Hits 3518 3518
Misses 1341 1341
Partials 363 363 Continue to review full report at Codecov.
|
sambhav
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit an issue where
/cnb/lifecycle/launcherwas hitting "permission denied" errors, and eventually tried this to see if it was a possible cause. My guess is that different container runtime implementations or perhaps file system drivers handle the omitted header entry for the directory differently.I'm running CRI-O on btrfs which I wouldn't expect to be the most common, so it would be unlikely to run in to this.