Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default proxy config option instead of finding it manually #905

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Use default proxy config option instead of finding it manually #905

merged 1 commit into from
Dec 9, 2021

Conversation

tylerphelan
Copy link
Contributor

@tylerphelan tylerphelan commented Dec 8, 2021 •
edited
Loading

  • This is all we need
  • Kept giturls

matthewmcnew
matthewmcnew reviewed Dec 8, 2021
View reviewed changes
pkg/git/fetch.go
err = remote.Fetch([]string{"refs/*:refs/*"}, &git2go.FetchOptions{
DownloadTags: git2go.DownloadTagsAll,
RemoteCallbacks: git2go.RemoteCallbacks{
CredentialsCallback: keychainAsCredentialsCallback(f.Keychain),
CertificateCheckCallback: certificateCheckCallback(f.Logger),
},
ProxyOptions: proxyOptions,
ProxyOptions: git2go.ProxyOptions{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Base automatically changed from upgrade-libgit2 to main December 9, 2021 19:07
@tylerphelan tylerphelan merged commit 372815c into main Dec 9, 2021
@tylerphelan tylerphelan deleted the fix-proxy branch December 9, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumez-k dumez-k dumez-k approved these changes

@tomkennedy513 tomkennedy513 tomkennedy513 approved these changes

@matthewmcnew matthewmcnew matthewmcnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylerphelan @matthewmcnew @tomkennedy513 @dumez-k