Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify documentation for Making your buildpack configurable #768

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Simplify documentation for Making your buildpack configurable #768

merged 1 commit into from
Sep 23, 2024

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Sep 22, 2024 •
edited
Loading

  • Simplify documentation for Making your buildpack configurable.
  • Fixes Using echo instead of cat is a bit complicated for beginners #767 .
  • As for why I forced push multiple times, it was mainly because I was a little curious why modifying the document would affect the actual build of the example, because I didn't actually have a golang programming environment installed locally.🫠

@linghengqian linghengqian requested a review from a team as a code owner September 22, 2024 03:55
@linghengqian
Simplify documentation for Making your buildpack configurable
f7e11dc 
Signed-off-by: linghengqian <linghengqian@outlook.com>
AidanDelaney
AidanDelaney approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this. It's a nice quality-of-life improvement for new users.

@AidanDelaney AidanDelaney merged commit 5b39011 into buildpacks:main Sep 23, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
@AidanDelaney
Simplify documentation for Making your buildpack configurable (#768)
49d14eb 
* Replace some `echo` instances with `cat`
* Clean up formatting of the shell scripts

Signed-off-by: linghengqian <linghengqian@outlook.com>
@linghengqian linghengqian deleted the docf-fix branch September 23, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanDelaney AidanDelaney AidanDelaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using echo instead of cat is a bit complicated for beginners
2 participants
@linghengqian @AidanDelaney