Allow overriding image creation time #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the SOURCE_DATE_EPOCH env var is set (to a number of seconds since the Unix epoch), its value will be used as the creation time of the image produced, and of config history values for each layer. This matches the behavior of tools like ko[0] and is the recommendation of https://reproducible-builds.org/ 0: https://github.com/google/ko#why-are-my-images-all-created-in-1970 Signed-off-by: Jason Hall <jasonhall@redhat.com>
imjasonh
force-pushed
the
source-date-epoch
branch
from
58865dd to
d1dc022
Compare
jabrown85
approved these changes
Feb 3, 2022
natalieparellano
approved these changes
Feb 9, 2022
1 task
Signed-off-by: Jason Hall <jasonhall@redhat.com>
|
I presume this can be closed, now that the alternative approach in #138 has merged? |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
SOURCE_DATE_EPOCHenv var is set (to a number of seconds since the Unix epoch), its value will be used as the creation time of the image produced, and of config history values for each layer.This matches the behavior of tools like
koand is the recommendation of https://reproducible-builds.org/See https://reproducible-builds.org/docs/source-date-epoch/
This was requested in a Slack thread, and I think unless there's a philosophical reason not to support it, the diff is small, and AFAIK will not have negative downstream effects (but isn't that always what they say?)
Anyway, let me know if there is some philosophical reason not to support it, or if you suspect there will be negative downstream effects.