Consolidate image options in imgutil package #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Previous commits changed function signatures like func NewImage(repoName string, dockerClient DockerClient, ops ...imgutil.ImageOption) (*Image, error) to expect imgutil.ImageOption instead of remote.ImageOption or whatever imgutil.ImageOption and remote.ImageOption are interchangeable when passed into the function but the signature needs a specific type Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
changed the title
jabrown85
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is really annoying in the lifecycle to have to construct the same list of options 3 times, once for local/remote/layout. By moving the options into the imgutil package, we can simplify the calling code.