Adds setters for OS/OSVersion/Architecture #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
image-os-setters
branch
from
703afa9 to
ec9e535
Compare
ekcasey
approved these changes
Oct 13, 2020
ekcasey
approved these changes
Oct 13, 2020
Comment on lines
+41
to
+43
| SetOS(string) error | ||
| SetOSVersion(string) error | ||
| SetArchitecture(string) error |
There was a problem hiding this comment.
Eventually I feel like these options make more sense as options on NewImage. Having constructor options instead of a setter would convey that is not valid to change these values for any image other than an empty image. But I can see how the awkwardness of our existing FromBase option makes that difficult to support without broader changes.
There was a problem hiding this comment.
Yeah, good call. I was also wondering how it will intersect with the needs of #54 which would also need very similar looking flags but to instead filter the FromBaseImage platform.
ameyer-pivotal
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
I can see @ekcasey's point about setting the OS to something other than the daemon OS. Otherwise 👍
- Keep as a noop setter for consitency remote - Compare against default value to fail fast Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
image-os-setters
branch
from
bb43139 to
bd9808c
Compare
micahyoung
commented
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to create valid, empty images without
FromBaseImageThis will be important for Windows buildpackages in pack (currently draft PR: buildpacks/pack#840), which will not use
FromBaseImage