Don't print warnings about run image for older platform apis (#757)

Signed-off-by: Natalie Arellano <narellano@vmware.com>
buildpacks · Nov 10, 2021 · 075a63e · 075a63e
1 parent f02ec0f
commit 075a63e
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 9 deletions.
diff --git a/acceptance/analyzer_test.go b/acceptance/analyzer_test.go
@@ -357,6 +357,29 @@ func testAnalyzerFunc(platformAPI string) func(t *testing.T, when spec.G, it spe
 						})
 					})
 				})
+
+				when("older platform", func() {
+					it("does not print log warnings", func() {
+						h.SkipIf(t, api.MustParse(platformAPI).AtLeast("0.7"), "Platform API >= 0.7 accepts run image")
+
+						output := h.DockerRunAndCopy(t,
+							containerName,
+							copyDir,
+							ctrPath("/layers/analyzed.toml"),
+							analyzeImage,
+							h.WithFlags(
+								"--env", "CNB_PLATFORM_API="+platformAPI,
+								"--env", "CNB_REGISTRY_AUTH="+analyzeRegAuthConfig,
+								"--env", "CNB_RUN_IMAGE="+analyzeRegFixtures.ReadOnlyRunImage,
+								"--network", analyzeRegNetwork,
+							),
+							h.WithArgs(ctrPath(analyzerPath), analyzeRegFixtures.SomeAppImage),
+						)
+
+						h.AssertStringDoesNotContain(t, output, `no stack metadata found at path ''`)
+						h.AssertStringDoesNotContain(t, output, `Previous image with name "" not found`)
+					})
+				})
 			})
 		})
 

diff --git a/cmd/lifecycle/analyzer.go b/cmd/lifecycle/analyzer.go
@@ -120,17 +120,19 @@ func (a *analyzeCmd) Args(nargs int, args []string) error {
 		a.platform06.groupPath = cmd.DefaultGroupPath(a.platform.API(), a.layersDir)
 	}
 
-	stackMD, err := readStack(a.stackPath)
-	if err != nil {
-		return cmd.FailErrCode(err, cmd.CodeInvalidArgs, "parse stack metadata")
-	}
+	if a.supportsRunImage() {
+		stackMD, err := readStack(a.stackPath)
+		if err != nil {
+			return cmd.FailErrCode(err, cmd.CodeInvalidArgs, "parse stack metadata")
+		}
 
-	if err := a.validateRunImageInput(); err != nil {
-		return cmd.FailErrCode(err, cmd.CodeInvalidArgs, "validate run image input")
-	}
+		if err := a.validateRunImageInput(); err != nil {
+			return cmd.FailErrCode(err, cmd.CodeInvalidArgs, "validate run image input")
+		}
 
-	if err := a.populateRunImage(stackMD, targetRegistry); err != nil {
-		return cmd.FailErrCode(err, cmd.CodeInvalidArgs, "populate run image")
+		if err := a.populateRunImage(stackMD, targetRegistry); err != nil {
+			return cmd.FailErrCode(err, cmd.CodeInvalidArgs, "populate run image")
+		}
 	}
 
 	return nil
@@ -240,6 +242,10 @@ func (aa analyzeArgs) analyze() (platform.AnalyzedMetadata, error) {
 }
 
 func (aa analyzeArgs) localOrRemote(fromImage string) (imgutil.Image, error) {
+	if fromImage == "" {
+		return nil, nil
+	}
+
 	if aa.useDaemon {
 		return local.NewImage(
 			fromImage,