Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile.d script failing on rebuild #12

Closed
ssisil opened this issue Aug 28, 2018 · 1 comment
Closed

profile.d script failing on rebuild #12

ssisil opened this issue Aug 28, 2018 · 1 comment

Comments

@ssisil
Copy link

ssisil commented Aug 28, 2018

Rebuilding sprint boot app with sample java build pack results in this error -

/buildpacks/sh.packs.samples.buildpack.java/0.0.1/bin/build: line 35: /launch/sh.packs.samples.buildpack.java/jdk/profile.d/jdk.sh: No such file or directory
@dgodd
Copy link
Contributor

dgodd commented Aug 29, 2018

We tracked this isssue down to a bug in the sample jdk buildpack.

The jdk buildpack was only creating the jdk layer directory if it would be different to the previous build's layer. However, it was always sourcing a profile script from that same directory.

We are submitting a PR to fix this issue in the sample jdk buildpack

dgodd added a commit to buildpacks/samples that referenced this issue Aug 29, 2018
@dgodd @jchesterpivotal
Fix rebuilding apps using JDK buildpack
f8e9213 
The jdk buildpack was only creating the jdk layer directory if it would
be different to the previous build's layer. However, it was always
sourcing a profile script from that same directory.

In fixing this, we have completed the 'TODO' items around using the
cache for the jdk.

[buildpacks/lifecycle#12]

Signed-off-by: Jacques Chester <jchester@pivotal.io>
@dgodd dgodd mentioned this issue Aug 29, 2018
Merged
@dgodd dgodd closed this as completed Aug 30, 2018
sclevine added a commit that referenced this issue Jul 8, 2019
@sclevine
Finish POC for RFCs #11 and #12
8247240 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine added a commit that referenced this issue Jul 9, 2019
@sclevine
Finish POC for RFCs #11 and #12
9979be9 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine added a commit that referenced this issue Jul 26, 2019
@sclevine
Finish POC for RFCs #11 and #12
cb9587e 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine added a commit that referenced this issue Aug 7, 2019
@sclevine
Finish POC for RFCs #11 and #12
9178535 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgodd @ssisil