Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter should invalidate the cache if it fails to write it #1407

Closed
tomkennedy513 opened this issue Oct 9, 2024 · 1 comment · Fixed by #1410
Closed

Exporter should invalidate the cache if it fails to write it #1407

tomkennedy513 opened this issue Oct 9, 2024 · 1 comment · Fixed by #1410
Assignees
Labels
status/ready type/enhancement New feature or request

Comments

@tomkennedy513
Copy link

Summary

Currently, when the exporter fails to write the cache after successfully exporting the image, it emits a warning without failure. This is acceptable behavior in my opinion, but when the caching fails, the exporter should at least invalidate the cache so that we don't have a corrupted cache causing issues in subsequent builds.


Proposal

The exporter should invalidate the cache whenever it fails to successfully write it, or if the cache it did write is somehow not valid.

Context

We are seeing restore failures in kpack due to a corrupt cache after the exporter only writes out a partial cache before failing.

@jabrown85
Copy link
Contributor

In the 10/17 meeting

We talked about adjusting restorer to check and fail if the cache doesn't match the metadata expected. Adding in this verification will not require a spec change unless we find performance or other issues during development of the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants